Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP/2 proxy fix, CI workflow ngtcp2-linux with caches #11527

Closed
wants to merge 10 commits into from
Closed

HTTP/2 proxy fix, CI workflow ngtcp2-linux with caches #11527

wants to merge 10 commits into from

Conversation

icing
Copy link
Contributor

@icing icing commented Jul 27, 2023 •
edited

Fix in h2 proxy tunnel: progress in ingress on sending

  • depending on what is tunneled, the proxy may never get
    invoked for receiving data explicitly. Not progressing
    ingress may lead to stalls due to missed WINDOW_UPDATEs.

CI:

  • add ngtcp2 workflow, replacing the separate ngtcp2 variations
  • use cache for common nghttpx / ngtcp2 / etc build
  • use cache for building mod_h2
  • uncached time: ~32 min (longer than before since all tls libs are built)
  • cached time: ~14 min

@github-actions github-actions bot added HTTP/3 h3 or quic related CI Continuous Integration labels Jul 27, 2023
@icing icing changed the title CI ngtcp2+quictls, use nghttpx cache as in quiche build CI ngtcp2, common workflow with cache Jul 27, 2023
@icing
putting lib versions into env section
ea3480b
@icing
moving stuff out of matric where github does not seem to like it
1b235a5
@icing
workflow rename to state platform
551c500
@icing
Fix in h2 proxy tunnel: progress in ingress on sending
3101e73 
- depending on what is tunneled, the proxy may never get
  invoked for receiving data explicitly. Not progressing
  ingress may lead to stalls due to missed WINDOW_UPDATEs.

CI:
- add a chache for building mod_h2
@icing icing changed the title CI ngtcp2, common workflow with cache HTTP/2 proxy fix, CI workflow ngtcp2-linux with caches Jul 27, 2023
@github-actions github-actions bot added the tests label Jul 27, 2023
@icing
Copy link
Contributor Author

icing commented Jul 27, 2023

Ready for merge now.

@bagder bagder closed this in a05cce7 Jul 27, 2023
ptitSeb pushed a commit to wasix-org/curl that referenced this pull request Sep 25, 2023
@icing @ptitSeb
http2: fix in h2 proxy tunnel: progress in ingress on sending
fc80318 
- depending on what is tunneled, the proxy may never get invoked for
  receiving data explicitly. Not progressing ingress may lead to stalls
  due to missed WINDOW_UPDATEs.

CI:
- add a chache for building mod_h2

Closes curl#11527
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
CI Continuous Integration HTTP/3 h3 or quic related tests
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@icing @bagder