Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONTRIBUTE.md updates #11504

Closed
wants to merge 2 commits into from
Closed

CONTRIBUTE.md updates #11504

wants to merge 2 commits into from

Conversation

rybak
Copy link
Contributor

@rybak rybak commented Jul 23, 2023

Two updates for docs/CONTRIBUTE.md.

File 'docs/CONTRIBUTE.md' includes a description of how one should write
commit messages in the curl project.  Different possible parts of the
message are enclosed in square brackets.  One exception is the section
describing how the curl project doesn't use "Signed-off-by" commit
trailers [1], which is enclosed in an opening curly brace paired with a
closing square bracket.

Fix the enclosing square brackets in description of "Signed-off-by"
trailers in commit messages in file 'docs/CONTRIBUTE.md'.

[1] See description of option '--signoff' in Git documentation:
    https://git-scm.com/docs/git-commit
Year ranges in copyrights were dropped in commits [1] and [2].
Verification of year ranges in copyrights was dropped from script
'scripts/copyright.pl' in commit [3].  However, the corresponding
passages in file 'docs/CONTRIBUTE.md' weren't updated.

Drop mentions of copyright year ranges from 'docs/CONTRIBUTE.md'.

[1] 2bc1d77 (copyright: update all copyright lines and remove year
    ranges, 2023-01-02)
[2] c46761b (tests/http: remove year ranges from copyrights,
    2023-03-14)
[3] 0e293ba (copyright.pl: cease doing year verifications, 2023-01-28)
@bagder bagder closed this in 971f03e Jul 23, 2023
@bagder
Copy link
Member

bagder commented Jul 23, 2023

Thanks!

bagder pushed a commit that referenced this pull request Jul 23, 2023
Year ranges in copyrights were dropped in commits [1] and [2].
Verification of year ranges in copyrights was dropped from script
'scripts/copyright.pl' in commit [3].  However, the corresponding
passages in file 'docs/CONTRIBUTE.md' weren't updated.

Drop mentions of copyright year ranges from 'docs/CONTRIBUTE.md'.

[1] 2bc1d77 (copyright: update all copyright lines and remove year
    ranges, 2023-01-02)
[2] c46761b (tests/http: remove year ranges from copyrights,
    2023-03-14)
[3] 0e293ba (copyright.pl: cease doing year verifications, 2023-01-28)

Closes #11504
@rybak rybak deleted the contribute.md-updates branch September 23, 2023 10:46
ptitSeb pushed a commit to wasix-org/curl that referenced this pull request Sep 25, 2023
File 'docs/CONTRIBUTE.md' includes a description of how one should write
commit messages in the curl project.  Different possible parts of the
message are enclosed in square brackets.  One exception is the section
describing how the curl project doesn't use "Signed-off-by" commit
trailers [1], which is enclosed in an opening curly brace paired with a
closing square bracket.

Fix the enclosing square brackets in description of "Signed-off-by"
trailers in commit messages in file 'docs/CONTRIBUTE.md'.

[1] See description of option '--signoff' in Git documentation:
    https://git-scm.com/docs/git-commit

Closes curl#11504
ptitSeb pushed a commit to wasix-org/curl that referenced this pull request Sep 25, 2023
Year ranges in copyrights were dropped in commits [1] and [2].
Verification of year ranges in copyrights was dropped from script
'scripts/copyright.pl' in commit [3].  However, the corresponding
passages in file 'docs/CONTRIBUTE.md' weren't updated.

Drop mentions of copyright year ranges from 'docs/CONTRIBUTE.md'.

[1] 2bc1d77 (copyright: update all copyright lines and remove year
    ranges, 2023-01-02)
[2] c46761b (tests/http: remove year ranges from copyrights,
    2023-03-14)
[3] 0e293ba (copyright.pl: cease doing year verifications, 2023-01-28)

Closes curl#11504
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants