socks: print IPv6 address in square brackets #11483
Closed
+19
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chilledheart
force-pushed
the
socks_print_ipv6_address
branch
from
471c23b
to
d4ee399
Compare
IPv6 address with port number should be printed with square brackets. > The [] style as expressed in [RFC3986] SHOULD be > employed, and is the default unless otherwise specified. refer: https://www.rfc-editor.org/rfc/rfc5952#section-6
Chilledheart
force-pushed
the
socks_print_ipv6_address
branch
from
d4ee399
to
3d41518
Compare
|
It seems unnecessary to add that much new (ifdef'ed) code when we already have most of the logic in place. I propose #11484 as an alternative fix for the same result. |
|
Your pr is better(more consistent with other part which prints IPv6 address with brackets as well). Feel free to close this one if yours gets merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IPv6 address with port number should be printed with square brackets.
refer: https://www.rfc-editor.org/rfc/rfc5952#section-6
with command line:
curl -v --proxy socks5://localhost:1083 -I http://localhost:12345previous:
current: