Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quiche: avoid NULL deref in debug logging #11454

Closed
wants to merge 2 commits into from
Closed

quiche: avoid NULL deref in debug logging #11454

wants to merge 2 commits into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Jul 17, 2023

Coverity reported "Dereference after null check"

If stream is NULL and the function exits, the logging must not deref it.

@bagder
quiche: avoid NULL deref in debug logging
b263f2f 
Coverity reported "Dereference after null check"

If stream is NULL and the function exits, the logging must not deref it.
@bagder bagder added the HTTP/3 h3 or quic related label Jul 17, 2023
@bagder bagder requested a review from icing July 17, 2023 18:52
icing
icing approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@icing icing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also fine, in #11455 I opted for an early return when stream is NULL.

@bagder
Copy link
Member Author

bagder commented Jul 17, 2023

Also fine, in #11455 I opted for an early return when stream is NULL.

I believe they're both decent choices. As I already did it this way I think I'll let it be for now.

@bagder bagder closed this in a141c3c Jul 17, 2023
@bagder bagder deleted the bagder/quiche-null-deref branch July 17, 2023 21:27
bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
@bagder @bch
quiche: avoid NULL deref in debug logging
117a6b3 
Coverity reported "Dereference after null check"

If stream is NULL and the function exits, the logging must not deref it.

Closes curl#11454
ptitSeb pushed a commit to wasix-org/curl that referenced this pull request Sep 25, 2023
@bagder @ptitSeb
quiche: avoid NULL deref in debug logging
9857efd 
Coverity reported "Dereference after null check"

If stream is NULL and the function exits, the logging must not deref it.

Closes curl#11454
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icing icing icing approved these changes

Assignees
No one assigned
Labels
HTTP/3 h3 or quic related
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bagder @icing