Bump ngtcp2 #11428
Bump ngtcp2 #11428
Conversation
- ngtcp2_crypto_openssl was renamed to ngtcp2_crypto_quictls.
|
Thanks! |
- ngtcp2_crypto_openssl was renamed to ngtcp2_crypto_quictls. Closes #11428
|
@tatsuhiro-t @bagder diff --git "a/CMakeLists.txt" "b/CMakeLists.txt"
index 49a44eabf..d25c9b388 100644
--- "a/CMakeLists.txt"
+++ "b/CMakeLists.txt"
@@ -602,7 +602,7 @@ if(USE_NGTCP2)
elseif(HAVE_BORINGSSL)
find_package(NGTCP2 REQUIRED BoringSSL)
else()
- find_package(NGTCP2 REQUIRED OpenSSL)
+ find_package(NGTCP2 REQUIRED QuicTLS)
endif()
CheckQuicSupportInOpenSSL()
elseif(USE_GNUTLS)
diff --git "a/CMake/FindNGTCP2.cmake" "b/CMake/FindNGTCP2.cmake"
index ff0d49e33..5d307371b 100644
--- "a/CMake/FindNGTCP2.cmake"
+++ "b/CMake/FindNGTCP2.cmake"
@@ -71,7 +71,7 @@ endif()
if(NGTCP2_FIND_COMPONENTS)
set(NGTCP2_CRYPTO_BACKEND "")
foreach(component IN LISTS NGTCP2_FIND_COMPONENTS)
- if(component MATCHES "^(BoringSSL|OpenSSL|wolfSSL|GnuTLS)")
+ if(component MATCHES "^(BoringSSL|QuicTLS|wolfSSL|GnuTLS)")
if(NGTCP2_CRYPTO_BACKEND)
message(FATAL_ERROR "NGTCP2: Only one crypto library can be selected")
endif()...All theses breaking changes in latest ng released modules without cmake regression validation (cf. ngtcp2/ngtcp2#858) became hard to follow |
This comment was marked as resolved.
This comment was marked as resolved.
|
@vszakats you mean if |
|
@icing: Oh sorry, it indeed is, confused this thread with one in ngtcp2. In this case, it most likely will continue to work with LibreSSL under the new name. The patch above looks necessary indeed, though I haven't made tests. The current curl-for-win daily builds are broken due to the renames, and I'm retrofitting a post-0.17.0 patch to get it back to work. Will find out later today how far it could go (this doesn't use CMake to build curl, so not affected by the patch above). That said a new ngtcp2 release would help a smooth upcoming curl release with H3. |
- ngtcp2_crypto_openssl was renamed to ngtcp2_crypto_quictls. Closes curl#11428
- ngtcp2_crypto_openssl was renamed to ngtcp2_crypto_quictls. Closes curl#11428
No description provided.