curl_fopen optimization #11419
Closed
curl_fopen optimization #11419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
WTF? A PR should describe the motivation behind a change. And so what's the optimization here? |
bagder
reviewed
Jul 11, 2023
lib/fopen.c
Outdated
| goto fail; | ||
| } | ||
| if (fstat(fileno(*fh), &sb) == -1 || !S_ISREG(sb.st_mode)) |
There was a problem hiding this comment.
make checksrc will tell you that we don't use spaces after if...
There was a problem hiding this comment.
My apologies for the oversight, fixed in next commit.
|
Last commit notes:
|
That's not how |
|
Sorry about that, another oversight in rush. I believe this should be good to go now. |
bagder
approved these changes
Jul 11, 2023
|
Thanks! |
ptitSeb
pushed a commit
to wasix-org/curl
that referenced
this pull request
Sep 25, 2023
Closes curl#11419
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.