Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop CMake from quietly ignoring missing Brotli #11376

Closed
wants to merge 1 commit into from
Closed

Stop CMake from quietly ignoring missing Brotli #11376

wants to merge 1 commit into from

Conversation

MichalPetryka
Copy link
Contributor

For some reason the CMake project was set to QUIET for Brotli instead of REQUIRED. This makes builds unexpectedly ignore missing Brotli even when CURL_BROTLI is enabled.

@MichalPetryka
Stop CMake from quietly ignoring missing Brotli
95a7b85 
For some reason the CMake project was set to `QUIET` for Brotli instead of `REQUIRED`. This makes builds unexpectedly ignore missing Brotli even when `CURL_BROTLI` is enabled.
@MichalPetryka
Copy link
Contributor Author

Discovered in microsoft/vcpkg#32108.

bagder
bagder approved these changes Jun 23, 2023
View reviewed changes
Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable to me!

@bagder
Copy link
Member

bagder commented Jun 23, 2023

Thanks!

@bagder bagder closed this in 4e115a1 Jun 23, 2023
@MichalPetryka MichalPetryka deleted the patch-1 branch June 24, 2023 13:39
bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
@MichalPetryka @bch
cmake: stop CMake from quietly ignoring missing Brotli
e6b93a8 
The CMake project was set to `QUIET` for Brotli instead of
`REQUIRED`. This makes builds unexpectedly ignore missing Brotli even
when `CURL_BROTLI` is enabled.

Closes curl#11376
ptitSeb pushed a commit to wasix-org/curl that referenced this pull request Sep 25, 2023
@MichalPetryka @ptitSeb
cmake: stop CMake from quietly ignoring missing Brotli
5bfa1b6 
The CMake project was set to `QUIET` for Brotli instead of
`REQUIRED`. This makes builds unexpectedly ignore missing Brotli even
when `CURL_BROTLI` is enabled.

Closes curl#11376
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
build cmake
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MichalPetryka @bagder