Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add CURLINFO_SCHEME, CURLINFO_PROTOCOL, and %{scheme} #1137

Closed
wants to merge 1 commit into from
Closed

add CURLINFO_SCHEME, CURLINFO_PROTOCOL, and %{scheme} #1137

wants to merge 1 commit into from

Conversation

gevaerts
Copy link
Contributor 

Adds access to the effectively used protocol/scheme to both libcurl and
curl, both in string and numeric (CURLPROTO_*) form.

Note that the string form will be uppercase, as it is just the internal
string.

As these strings are declared internally as const, and all other strings
returned by curl_easy_getinfo() are de-facto const as well, string handling
in getinfo.c got const-ified.

@mention-bot
Copy link

@gevaerts, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bagder, @captain-caveman2k and @philipc to be potential reviewers.

bagder
bagder approved these changes Nov 23, 2016
View reviewed changes
Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks clean and I see no problems. Ready for merge!

@gevaerts
add CURLINFO_SCHEME, CURLINFO_PROTOCOL, and %{scheme}
d29e626 
    Adds access to the effectively used protocol/scheme to both libcurl and
    curl, both in string and numeric (CURLPROTO_*) form.

    Note that the string form will be uppercase, as it is just the internal
    string.

    As these strings are declared internally as const, and all other strings
    returned by curl_easy_getinfo() are de-facto const as well, string handling
    in getinfo.c got const-ified.
@bagder bagder closed this in ba410f6 Nov 24, 2016
@bagder
Copy link
Member

bagder commented Nov 24, 2016

thanks!

vulpine pushed a commit to vulpine/curl that referenced this pull request Nov 30, 2016
@gevaerts
add CURLINFO_SCHEME, CURLINFO_PROTOCOL, and %{scheme}
0d1b9d3 
Adds access to the effectively used protocol/scheme to both libcurl and
curl, both in string and numeric (CURLPROTO_*) form.

Note that the string form will be uppercase, as it is just the internal
string.

As these strings are declared internally as const, and all other strings
returned by curl_easy_getinfo() are de-facto const as well, string
handling in getinfo.c got const-ified.

Closes curl#1137
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gevaerts @mention-bot @bagder