Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HTTP/2 and H2-PROXY alive check and proxy drain #11368

Closed
wants to merge 2 commits into from
Closed

Fix HTTP/2 and H2-PROXY alive check and proxy drain #11368

wants to merge 2 commits into from

Conversation

icing
Copy link
Contributor

@icing icing commented Jun 22, 2023 •
edited

  • fix HTTP/2 check to not declare a connection dead when the read attempt results in EAGAIN
  • add H2-PROXY alive check as for HTTP/2 that was missing and is needed
  • add attach/detach around Curl_conn_is_alive() and remove these in filter methods
  • add checks for number of connections used in some test_10 proxy tunneling tests
  • fix stalling receives by setting drain when not all available tunnel data had been consumed. This fixes the gnutls pytest failures on my machine.

@icing
Fix HTTP/2 and H2-PROXY connection alive check
4e571c5 
- fix HTTP/2 check to not declare a connection dead when
  the read attempt results in EAGAIN
- add H2-PROXY alive check as for HTTP/2 that was missing
  and is needed
- add attach/detach around Curl_conn_is_alive() and remove
  these in filter methods
- add checks for number of connections used in some test_10
  proxy tunneling tests
@github-actions github-actions bot added the tests label Jun 22, 2023
@icing icing changed the title Fix HTTP/2 and H2-PROXY connection alive check Fix HTTP/2 and H2-PROXY alive check and proxy drain Jun 22, 2023
@bagder bagder closed this in 873b958 Jun 22, 2023
@bagder
Copy link
Member

bagder commented Jun 22, 2023

Thanks!

@icing icing mentioned this pull request Jun 22, 2023
Closed
bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
@icing @bch
http2: h2 and h2-PROXY connection alive check fixes
3cd1306 
- fix HTTP/2 check to not declare a connection dead when
  the read attempt results in EAGAIN
- add H2-PROXY alive check as for HTTP/2 that was missing
  and is needed
- add attach/detach around Curl_conn_is_alive() and remove
  these in filter methods
- add checks for number of connections used in some test_10
  proxy tunneling tests

Closes curl#11368
ptitSeb pushed a commit to wasix-org/curl that referenced this pull request Sep 25, 2023
@icing @ptitSeb
http2: h2 and h2-PROXY connection alive check fixes
0944f67 
- fix HTTP/2 check to not declare a connection dead when
  the read attempt results in EAGAIN
- add H2-PROXY alive check as for HTTP/2 that was missing
  and is needed
- add attach/detach around Curl_conn_is_alive() and remove
  these in filter methods
- add checks for number of connections used in some test_10
  proxy tunneling tests

Closes curl#11368
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
connecting & proxies HTTP/2 tests
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@icing @bagder