Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests broken with native Windows perl #11350

Closed
MarcelRaad opened this issue Jun 20, 2023 · 4 comments
Closed

Tests broken with native Windows perl #11350

MarcelRaad opened this issue Jun 20, 2023 · 4 comments
Labels
tests Windows Windows-specific

Comments

@MarcelRaad
Copy link
Member

MarcelRaad commented Jun 20, 2023 •
edited

I did this

From an MSYS2 shell on Windows:

cd tests && ./runtests.pl

I expected the following

Successful test run. Instead, I get:

No such signal: SIGUSR1 at ./runtests.pl line 274.

This is with MSYS2's perl used in its MINGW32 shell:

$ perl --version
This is perl 5, version 32, subversion 1 (v5.32.1) built for MSWin32-x86-multi-thread-64int

Strangely, the error doesn't appear in the CI.

curl/libcurl version

2fe5241

operating system

Windows 10 (MSYS2)

CC @dfandrich
@MarcelRaad MarcelRaad added tests Windows Windows-specific labels Jun 20, 2023
@dfandrich
Copy link
Contributor

dfandrich commented Jun 20, 2023 via email

@MarcelRaad
Copy link
Member Author

MarcelRaad commented Jun 20, 2023 •
edited

perl -e 'print join(" ", keys %SIG)' says:

ABRT ALRM BREAK CHLD CLD CONT FPE HUP ILL INT KILL NUM05 NUM06 NUM07 NUM10 NUM12 NUM16 NUM17 NUM18 NUM19 NUM24 PIPE QUIT SEGV STOP TERM

Maybe I also did something wrong, this is the first time I've set up an MSYS2 development environment in a long time, and the last time I've manually run the tests in MSYS2 was last year.

@dfandrich
Copy link
Contributor

dfandrich commented Jun 20, 2023 via email

@MarcelRaad
Copy link
Member Author

I've also just read that Windows
doesn't even support sending signals like I'm using SIGUSR1 for, so maybe an
error setting this signal handler should simply be ignored on Windows.

Sounds good to me!

@MarcelRaad MarcelRaad changed the title Tests broken on Windows Tests broken with native Windows perl Jun 20, 2023
dfandrich added a commit that referenced this issue Jun 22, 2023
@dfandrich
runtests: work around a perl without SIGUSR1
01505e4 
At least msys2 perl v5.32.1 doesn't seem to define this signal. Since
this signal is only used for debugging, just ignore if setting it fails.

Reported-by: Marcel Raad
Fixes #11350
Closes #11366
@dfandrich dfandrich mentioned this issue Jun 22, 2023
Closed
bch pushed a commit to bch/curl that referenced this issue Jul 19, 2023
@dfandrich @bch
runtests: work around a perl without SIGUSR1
c5c48f5 
At least msys2 perl v5.32.1 doesn't seem to define this signal. Since
this signal is only used for debugging, just ignore if setting it fails.

Reported-by: Marcel Raad
Fixes curl#11350
Closes curl#11366
ptitSeb pushed a commit to wasix-org/curl that referenced this issue Sep 25, 2023
@dfandrich @ptitSeb
runtests: work around a perl without SIGUSR1
6e18206 
At least msys2 perl v5.32.1 doesn't seem to define this signal. Since
this signal is only used for debugging, just ignore if setting it fails.

Reported-by: Marcel Raad
Fixes curl#11350
Closes curl#11366
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests Windows Windows-specific
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

runtests: work around a perl without SIGUSR1 curl/curl
2 participants
@dfandrich @MarcelRaad