Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Whether does it need to free sha256sumdigest before return operation in the Curl_pin_peer_pubkey function #11306

Closed
lizhuang0630 opened this issue Jun 12, 2023 · 0 comments
Closed

Whether does it need to free sha256sumdigest before return operation in the Curl_pin_peer_pubkey function #11306

lizhuang0630 opened this issue Jun 12, 2023 · 0 comments
Assignees
@bagder
Labels
memory-leak TLS

Comments

@lizhuang0630
Copy link

I did this

lib\vtls\vtls.c line：913 function: Curl_pin_peer_pubkey
image

I expected the following

Whether does it need to free sha256sumdigest before return operation.

curl/libcurl version

[curl -V output]

operating system
@bagder bagder self-assigned this Jun 12, 2023
bagder added a commit that referenced this issue Jun 12, 2023
@bagder
vtls: avoid memory leak if sha256 call fails
7b787c5 
... in the pinned public key handling function.

Reported-by: lizhuang0630 on github
Fixes #11306
@bagder bagder mentioned this issue Jun 12, 2023
Closed
@bagder bagder closed this as completed in a4a5e43 Jun 12, 2023
bch pushed a commit to bch/curl that referenced this issue Jul 19, 2023
@bagder @bch
vtls: avoid memory leak if sha256 call fails
650924d 
... in the pinned public key handling function.

Reported-by: lizhuang0630 on github
Fixes curl#11306
Closes curl#11307
ptitSeb pushed a commit to wasix-org/curl that referenced this issue Sep 25, 2023
@bagder @ptitSeb
vtls: avoid memory leak if sha256 call fails
11243df 
... in the pinned public key handling function.

Reported-by: lizhuang0630 on github
Fixes curl#11306
Closes curl#11307
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bagder bagder

Labels
memory-leak TLS
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

vtls: avoid memory leak if sha256 call fails curl/curl
2 participants
@bagder @lizhuang0630