docs: Can't typedef bool in c23 #11299
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bool is a reserved keyword in c23, UB ahead.
bagder
reviewed
Jun 12, 2023
| @@ -36,7 +36,10 @@ | |||
| /* curl stuff */ | |||
| #include <curl/curl.h> | |||
|
|
|||
| #if defined __STDC_VERSION__ && __STDC_VERSION__ > 201710L | |||
There was a problem hiding this comment.
Did you perchance mean <= 201710L ? 201710L seems to be the value that identifies c18
bagder
added a commit
that referenced
this pull request
Jun 15, 2023
Apparently this cannot be done in c23 Reported-by: Cristian Rodríguez Fixes #11299
bch
pushed a commit
to bch/curl
that referenced
this pull request
Jul 19, 2023
Apparently this cannot be done in c23 Reported-by: Cristian Rodríguez Fixes curl#11299 Closes curl#11319
ptitSeb
pushed a commit
to wasix-org/curl
that referenced
this pull request
Sep 25, 2023
Apparently this cannot be done in c23 Reported-by: Cristian Rodríguez Fixes curl#11299 Closes curl#11319
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bool is a reserved keyword in c23.
Reserved keywords must not be redefined or UB ocurrs.