Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused functions, make single-use functions static #11174

Closed
wants to merge 2 commits into from
Closed

remove unused functions, make single-use functions static #11174

wants to merge 2 commits into from

Conversation

bagder
Copy link
Member

@bagder bagder commented May 22, 2023

No description provided.

@bagder
Copy link
Member Author

bagder commented May 22, 2023

@icing Curl_cf_def_close is a function that is only unit-tested and never used in libcurl itself. Isn't that odd?

@icing
Copy link
Contributor

icing commented May 22, 2023

@icing Curl_cf_def_close is a function that is only unit-tested and never used in libcurl itself. Isn't that odd?

If every filter we have adds its own method, it is an offering never used, indeed.

@bagder bagder marked this pull request as ready for review May 22, 2023 14:40
@bagder
Copy link
Member Author

bagder commented May 22, 2023

If every filter we have adds its own method, it is an offering never used, indeed.

I moved it into an #ifdef DEBUGBUILD to make the unit test remain functional without adding unused code to non-debug builds.

@bagder bagder closed this in 8e85764 May 23, 2023
@bagder bagder deleted the bagder/static-tidy branch May 23, 2023 09:09
bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
@bagder @bch
lib: remove unused functions, make single-use static
14b1a92 
Closes curl#11174
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bagder @icing