Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typos #11171

Closed
musvaage opened this issue May 21, 2023 · 3 comments
Closed

typos #11171

musvaage opened this issue May 21, 2023 · 3 comments
Assignees

Comments

@musvaage
Copy link

seems you don't have a template for a blank issue

Are any of the herein identifiable files not to be corrected?

ADVISORY
Treating
accommodate
acknowledged
additive
address
adjustments
available
built
compare
enforce
expired
harness
implementation
initialization
insensitivity
miscellaneous
locations
pretension
requests
returned
specially
terminator
temporary
there
transitive
unless
warranties

$ grep -nr ADVISSORY curl
curl/docs/SECURITY-PROCESS.md:59:  `SECURITY-ADVISSORY.md` for help on creating the advisory.
$ grep -nr Treaing curl
curl/lib/vtls/sectransp.c:2722:      /* Treaing non-fatal error as fatal like before */
$ grep -nr accomodate curl
curl/lib/http2.c:84:/* We need to accomodate the max number of streams with their window
$ grep -nr ackknowledged curl
curl/lib/vquic/curl_ngtcp2.c:1446:  /* The server ackknowledged `datalen` of bytes from our request body.
$ grep -nr addative curl
curl/tests/unit/unit1399.c:79: * t_connect, t_appconnect, t_pretransfer, and t_starttransfer are addative.
$ grep -nr adddress curl
curl/lib/urlapi.c:654:#define HOST_BAD     -2 /* bad IPv4 adddress */
$ grep -nr adjustsments curl
curl/m4/curl-confopts.m4:479:dnl performs necessary checks and adjustsments needed
$ grep -nr availbale curl
curl/tests/unit/unit2600.c:392:     although another address of the 'wrong' family is availbale */
curl/tests/unit/unit2600.c:396:     although another address of the 'wrong' family is availbale */
$ grep -nr bullt curl
curl/tests/data/test178:56:# bullt-in curl returns weird_server_reply
curl/tests/data/test415:56:# bullt-in curl returns weird_server_reply
$ grep -nr compapare curl
curl/tests/data/test31:14:# compapare with the exact server contents unlesss it too sends the data
$ grep -nr enfore curl
curl/lib/http2.c:330:  /* We handle window updates ourself to enfore buffer limits */
curl/lib/cf-h2-proxy.c:258:  /* We handle window updates ourself to enfore buffer limits */
$ grep -nr expried curl
curl/tests/data/test420:37:Setting cookies set with expried dates that were loaded from jar
$ grep -nr harneess curl
curl/tests/devtest.pl:27:# runtests.pl harneess. Don't try to use this unless you know what you're
$ grep -nr implemenation curl
curl/lib/cf-socket.c:750: * This happens often on TLS connections where the TLS implemenation
$ grep -nr initializion curl
curl/docs/examples/htmltitle.cpp:275:    fprintf(stderr, "Connection initializion failed\n");
$ grep -nr insensivity curl
curl/packages/OS400/curl.inc.in:2284:      *  Renaming CURLMsg to CURL_Msg to avoid case-insensivity name clash.
$ grep -nr miscellanous curl
curl/tests/testutil.pm:25:# This module contains miscellanous functions needed in several parts of
$ grep -nr " ocations" curl
curl/src/tool_cfgable.h:121:                               when following ocations, even when hostname
$ grep -nr pretention curl
curl/lib/vtls/x509asn1.c:175: * Please note there is no pretention here to rewrite a full SSL library.
$ grep -nr requesets curl
curl/tests/data/test1906:33:# The tool does two requesets, the first sets CURLOPT_PORT to 1
$ grep -nr rerturned curl
curl/src/tool_cb_rea.c:90:  /* when select() rerturned zero here, it timed out */
$ grep -nr specicially curl
curl/docs/examples/httpput.c:104:    /* provide the size of the upload, we specicially typecast the value
$ grep -nr terminatior curl
curl/lib/curl_addrinfo.c:277:    size_t namelen = strlen(he->h_name) + 1; /* include null-terminatior */
$ grep -nr themporary curl
curl/packages/OS400/initscript.sh:211:        #               the source file and we compile that themporary file.
$ grep -nr theree curl
curl/lib/cookie.c:1724:   * If we reach here we have successfully written a cookie file so theree is
$ grep -nr transtive curl
curl/docs/INSTALL.md:426:LIBS="-lssl -lcrypto -lc++" # For OpenSSL/BoringSSL. In general, you will need to the SSL/TLS layer's transtive dependencies if you are linking statically.
$ grep -nr unlesss curl
curl/tests/data/test31:14:# compapare with the exact server contents unlesss it too sends the data
$ grep -nr warrantees curl
curl/packages/vms/curl_release_note_start.txt:5:as-is with no warrantees.
$ 

These also are questionable.

addampersand
password

$ grep -nr addamperand curl
curl/lib/urlapi.c:1867:      bool addamperand = querylen && (u->query[querylen -1] != '&');
curl/lib/urlapi.c:1875:        if(addamperand) {
$ grep -nr passwood curl
curl/lib/vauth/vauth.h:222:                                         const char *passwood,
$ 
@bagder bagder self-assigned this May 21, 2023
bagder added a commit that referenced this issue May 21, 2023
Reported-by: musvaage on github
Fixes #11171
@bagder
Copy link
Member

bagder commented May 21, 2023

addampersand

That's just a variable name, I think it's fine.

@musvaage
Copy link
Author

musvaage commented May 22, 2023

That's just a variable name, I think it's fine.

Well that's to the discretion of a repo Member.


My only comment on your patch is probably the original intent was specifically.

specially

$ grep -nr specicially curl
curl/docs/examples/httpput.c:104:    /* provide the size of the upload, we specicially typecast the value
$ 

The comment block.

$ ed -s  curl/docs/examples/httpput.c <<<'104,105p'
    /* provide the size of the upload, we specicially typecast the value
       to curl_off_t since we must be sure to use the correct data size */
$ 

Your patch simply removed that string.

docs/examples/httpput.c

-    /* provide the size of the upload, we specicially typecast the value
-       to curl_off_t since we must be sure to use the correct data size */
+    /* provide the size of the upload, we typecast the value to curl_off_t
+       since we must be sure to use the correct data size */

@bagder
Copy link
Member

bagder commented May 22, 2023

I removed it, yes. I think it improves the comment.

bagder added a commit that referenced this issue May 23, 2023
Reported-by: musvaage on github
Fixes #11171
Closes #11172
@bagder bagder closed this as completed in 127eb0d May 23, 2023
bch pushed a commit to bch/curl that referenced this issue Jul 19, 2023
Reported-by: musvaage on github
Fixes curl#11171
Closes curl#11172
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants