Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FreeBSD 14 "owns" struct http_req #11163

Closed
bagder opened this issue May 20, 2023 · 1 comment
Closed

FreeBSD 14 "owns" struct http_req #11163

bagder opened this issue May 20, 2023 · 1 comment
Labels

Comments

@bagder
Copy link
Member

bagder commented May 20, 2023

(Found here: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=271526, reported by "O. Hartmann")

Just updating ports: curl 8.0.1 -> 8.1


[...]
In file included from cf-socket.c:56:
In file included from ../lib/urldata.h:168:
../lib/http.h:263:8: error: redefinition of 'http_req'
struct http_req {
       ^
/usr/include/netinet/tcp.h:466:8: note: previous definition is here
struct http_req {

I would say this is a bug in their netinet/tcp.h header file, but I doubt that helps. We should rename our struct.

@bagder bagder added the build label May 20, 2023
bagder added a commit that referenced this issue May 20, 2023
Because FreeBSD 14 kidnapped the name.

Fixes #11163
@bagder bagder closed this as completed in 54ce13d May 20, 2023
@emaste
Copy link

emaste commented May 23, 2023

I would say this is a bug in their netinet/tcp.h header file

It certainly is, and we (FreeBSD) need to change it. But thank you for this change so that curl won't be broken until then.

bch pushed a commit to bch/curl that referenced this issue Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

2 participants