Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtests: internal IPC fixes & test update #11160

Closed
wants to merge 3 commits into from
Closed

runtests: internal IPC fixes & test update #11160

wants to merge 3 commits into from

Conversation

dfandrich
Copy link
Contributor

  • use the correct fd after select
  • handle interrupted reads from IPC pipes
  • fix the log directory in test425

@dfandrich
runtests: handle interrupted reads from IPC pipes
0d25509 
These can be interrupted by signals, especially SIGINT to shut down, and
must be restarted so the IPC call arrives correctly. If the read just
returns an error instead, the IPC calling state will go out of sync and
a proper shutdown won't happen.

Ref: #10818
@dfandrich
test425: fix the log directory for the upload
09167f3 
This must be %LOGDIR to let it work with parallel tests.

Ref: #10969
@dfandrich
runtests: use the correct fd after select
b23d3fe 
The code was using the wrong fd when determining which runner was ready
with a response.

Ref: #10818
Closes #11160
@github-actions github-actions bot added the tests label May 19, 2023
@curl curl deleted a comment from Sharlo3 May 20, 2023
@dfandrich dfandrich closed this in c95ca8d May 21, 2023
@dfandrich dfandrich deleted the dfandrich/pr11160 branch May 21, 2023 05:16
bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
@dfandrich @bch
runtests: use the correct fd after select
5a2a50b 
The code was using the wrong fd when determining which runner was ready
with a response.

Ref: curl#10818
Closes curl#11160
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tests
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@dfandrich