checksrc: disallow spaces before labels #11134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagder
approved these changes
May 18, 2023
|
I'd suggest extending the query to catch labels with underscores and digits: if($prevl !~ /\?\z/ && $l =~ /^ +([A-Za-z_][A-Za-z0-9_]*):$/ && $1 ne 'default') { |
vszakats
added a commit
to vszakats/libssh2
that referenced
this pull request
May 18, 2023
Also update two labels to match the rest of the source. checksrc update credit: Emanuele Torre @emanuele6 Ref: curl/curl#11134
|
Done 👍 |
vszakats
reviewed
May 18, 2023
|
Oops =) |
|
Thanks! With this, checksrc detected a few more issues: |
vszakats
added a commit
to libssh2/libssh2
that referenced
this pull request
May 18, 2023
Also update two labels to match the rest of the source. checksrc update credit: Emanuele Torre @emanuele6 Ref: curl/curl#11134 Closes #1042
Out of 415 labels throughout the code base, 86 of those labels were not at the start of the line. Which means labels always at the start of the line is the favoured style overall with 329 instances. Out of the 86 labels not at the start of the line: * 75 were indented with the same indentation level of the following line * 8 were indented with exactly one space * 2 were indented with one fewer indentation level then the following line * 1 was indented with the indentation level of the following line minus three space (probably unintentional) Co-Authored-By: Viktor Szakats
vszakats
approved these changes
May 18, 2023
|
Thanks, both of you! |
lampmanyao
pushed a commit
to lampmanyao/libssh2
that referenced
this pull request
Jul 16, 2023
Also update two labels to match the rest of the source. checksrc update credit: Emanuele Torre @emanuele6 Ref: curl/curl#11134 Closes libssh2#1042
bch
pushed a commit
to bch/curl
that referenced
this pull request
Jul 19, 2023
Out of 415 labels throughout the code base, 86 of those labels were not at the start of the line. Which means labels always at the start of the line is the favoured style overall with 329 instances. Out of the 86 labels not at the start of the line: * 75 were indented with the same indentation level of the following line * 8 were indented with exactly one space * 2 were indented with one fewer indentation level then the following line * 1 was indented with the indentation level of the following line minus three space (probably unintentional) Co-Authored-By: Viktor Szakats Closes curl#11134
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Out of 223 labels throughout the code base, 65 of those labels were not at the start of the line. Which means labels always at the start of the line is the favoured style overall with 158 instances.
Out of the 65 labels not at the start of the line: