Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build error on OS400 - chkstrings unexpected last string values #11132

Closed
jonrumsey opened this issue May 17, 2023 · 0 comments
Closed

Build error on OS400 - chkstrings unexpected last string values #11132

jonrumsey opened this issue May 17, 2023 · 0 comments

Comments

@jonrumsey
Copy link
Contributor

I did this

Build 8.1.0 on OS400 encountering a build error;
STRING_LASTZEROTERMINATED(77) is not expected value(76).…STRING_LAST(79) is not expected value(77).…curl_easy_setopt_ccsid() in packages/OS400/ccsidcurl.c may need updating if new strings are provided as input via the curl API.…ERROR: CHKSTRINGS failed!

STRING_AWS_SIGV4 was recategorized in lib/urldata.h from a binary string to a null terminated character string under commit 3f0b81c. Whilst curl_easy_setop_ccsid() already handles CURLOPT_AWS_SIGV4, the compensating change to chkstrings.c was not made.

I expected the following

Clean build.

curl/libcurl version

8.1.0

operating system

OS400 V7R4M0
@jonrumsey jonrumsey mentioned this issue May 17, 2023
Closed
@bagder bagder closed this as completed in 9438bd2 May 18, 2023
bch pushed a commit to bch/curl that referenced this issue Jul 19, 2023
@jonrumsey @bch
os400: update chkstrings.c
619169e 
Compensate changes for recent changes to urldata.h to reclassify
STRING_AWS_SIGV4.

Fixes curl#11132
Closes curl#11133
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jonrumsey