Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cURL 8.1.0 URL using bad/illegal format or missing URL for URL starting with digit #11129

Closed
PkAIR opened this issue May 17, 2023 · 1 comment
Closed

cURL 8.1.0 URL using bad/illegal format or missing URL for URL starting with digit #11129

PkAIR opened this issue May 17, 2023 · 1 comment
Assignees
@bagder
Labels
regression URL

Comments

@PkAIR
Copy link

PkAIR commented May 17, 2023

With latest release of cURL 8.1.0 now it impossible to use it for get/put requests with URLs starting with digits.

I did this

curl http://10.xxx.xxx.xxx/composer/packages.json

I expected the following

File was downloaded but got URL using bad/illegal format or missing URL

curl/libcurl version

cURL 8.1.0

operating system

Latest Alpine docker image
@PkAIR PkAIR changed the title cURL 8.1.0 URL using bad/illegal format or missing URL for URL starting with digit cURL 8.1.0 URL using bad/illegal format or missing URL for URL starting with digit May 17, 2023
@bagder bagder added the URL label May 17, 2023
@bagder bagder self-assigned this May 17, 2023
@bagder
Copy link
Member

bagder commented May 17, 2023 •
edited

My apologies.

This regression is considered important enough to warrant a follow-up patch release. 8.1.1 is now due to ship on May 23, 2023. Stay tuned. We will also merge other bugfixes that are ready to include in this release.

bagder added a commit that referenced this issue May 17, 2023
@bagder
urlapi: allow numerical parts in the host name
a2815af 
It can only be an IPv4 address if the last part is all digits, otherwise
it is a host name.

Extended test 1560 accordingly.

Reported-by: Pavel Kalyugin
Fixes #11129
@bagder bagder mentioned this issue May 17, 2023
Closed
@bagder bagder pinned this issue May 18, 2023
@bagder bagder mentioned this issue May 18, 2023
Closed
@xquery xquery mentioned this issue May 18, 2023
Open
bagder added a commit that referenced this issue May 18, 2023
@bagder
url: provide better error message when URLs fail to parse
865efbb 
By providing the URL API error message into the error message.

Ref: #11129
@bagder bagder mentioned this issue May 18, 2023
Closed
bagder added a commit that referenced this issue May 18, 2023
@bagder
urlapi: allow numerical parts in the host name
3a465f0 
It can only be an IPv4 address if the last part is all digits, otherwise
it is a host name. Even slightly wrong IPv4 will now be passed through
as a host name.

Regression from 17a15d8 shipped in 8.1.0

Extended test 1560 accordingly.

Reported-by: Pavel Kalyugin
Fixes #11129
Closes #11131
bagder added a commit that referenced this issue May 18, 2023
@bagder
urlapi: allow numerical parts in the host name
87fef72 
It can only be an IPv4 address if all parts are all digits and no more than
four parts, otherwise it is a host name. Even slightly wrong IPv4 will now be
passed through as a host name.

Regression from 17a15d8 shipped in 8.1.0

Extended test 1560 accordingly.

Reported-by: Pavel Kalyugin
Fixes #11129
Closes #11131
bagder added a commit that referenced this issue May 18, 2023
@bagder
url: provide better error message when URLs fail to parse
f1e5d8a 
By providing the URL API error message into the error message.

Ref: #11129
Closes #11137
bagder added a commit that referenced this issue May 18, 2023
@bagder
urlapi: allow numerical parts in the host name
3fefe80 
It can only be an IPv4 address if all parts are all digits and no more than
four parts, otherwise it is a host name. Even slightly wrong IPv4 will now be
passed through as a host name.

Regression from 17a15d8 shipped in 8.1.0

Extended test 1560 accordingly.

Reported-by: Pavel Kalyugin
Fixes #11129
Closes #11131
@bagder bagder closed this as completed in 92772e6 May 19, 2023
@user8446 user8446 mentioned this issue May 19, 2023
Closed
@bagder bagder unpinned this issue May 22, 2023
@emanuele6 emanuele6 mentioned this issue May 23, 2023
Closed
@dfandrich dfandrich mentioned this issue May 28, 2023
Closed
@bagder bagder mentioned this issue Jun 5, 2023
Closed
@dfandrich dfandrich mentioned this issue Jun 7, 2023
Closed
bch pushed a commit to bch/curl that referenced this issue Jul 19, 2023
@bagder @bch
url: provide better error message when URLs fail to parse
bdd92e2 
By providing the URL API error message into the error message.

Ref: curl#11129
Closes curl#11137
bch pushed a commit to bch/curl that referenced this issue Jul 19, 2023
@bagder @bch
urlapi: allow numerical parts in the host name
fe9d191 
It can only be an IPv4 address if all parts are all digits and no more than
four parts, otherwise it is a host name. Even slightly wrong IPv4 will now be
passed through as a host name.

Regression from 17a15d8 shipped in 8.1.0

Extended test 1560 accordingly.

Reported-by: Pavel Kalyugin
Fixes curl#11129
Closes curl#11131
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bagder bagder

Labels
regression URL
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

urlapi: allow numerical parts in the host name curl/curl
2 participants
@bagder @PkAIR