Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update curl_easy_getinfo doc #11126

Closed
wants to merge 4 commits into from
Closed

Update curl_easy_getinfo doc #11126

wants to merge 4 commits into from

Conversation

Hind-M
Copy link
Contributor

@Hind-M Hind-M commented May 17, 2023

Fix #11123

bagder
bagder reviewed May 17, 2023
View reviewed changes
Copy link
Member

@bagder bagder left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think your edit here shows the insanity in listing all the types in this manner. The documentation as well as the header comment become unreadable wall of texts.

I think we should rather remove the types there and say that they can return types and that each option's type is documented in the corresponding man page for the option.

@bagder bagder closed this in de522c5 May 18, 2023
@bagder
Copy link
Member

bagder commented May 18, 2023

Thanks!

@Hind-M Hind-M deleted the libcurl_api_doc branch May 19, 2023 08:22
@bagder bagder mentioned this pull request May 20, 2023
Closed
bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
@Hind-M @bch
curl_easy_getinfo: clarify on return data types
ab0ae34 
Closes curl#11126
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
libcurl API
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing info for the third arg in curl_easy_getinfo documentation
2 participants
@Hind-M @bagder