Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completely remove the disabled USE_RECV_BEFORE_SEND_WORKAROUND from code #11118

Closed
wants to merge 2 commits into from
Closed

Completely remove the disabled USE_RECV_BEFORE_SEND_WORKAROUND from code #11118

wants to merge 2 commits into from

Conversation

icing
Copy link
Contributor

@icing icing commented May 16, 2023

  • need to check how test 1517 now runs in Windows CI

@icing
Completely remove the disabled USE_RECV_BEFORE_SEND_WORKAROUND from code
f547390 
- need to check how test 1517 now runs in Windows CI
@github-actions github-actions bot added the tests label May 16, 2023
@icing
Disable test1517 on Windows, as before.
0344f39 
Windows TCP does not deliver data received correctly when handling
a CONNABORT afterwards. Instead it directly reports the error
condition which makes us unable to read the HTTP response that
came before.
@bagder
Copy link
Member

bagder commented May 18, 2023

Thanks!

@bagder bagder closed this in 408eb87 May 18, 2023
bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
@icing @bch
cf-socket: completely remove the disabled USE_RECV_BEFORE_SEND_WORKAR…
77eaeb8 
…OUND

Closes curl#11118
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
tests
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@icing @bagder