Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url: fix null dispname for --connect-to option #11106

Closed
wants to merge 1 commit into from
Closed

url: fix null dispname for --connect-to option #11106

wants to merge 1 commit into from

Conversation

smaeda-ks
Copy link
Contributor

@smaeda-ks smaeda-ks commented May 12, 2023 •
edited

parseurlandfillconn() runs before parse_connect_to_slist() (which is where conn->bits.conn_to_host is set), so checking conn->bits.conn_to_host in parseurlandfillconn() would always be FALSE, and hence curl is always reporting (nil) dispname in output:

$ curl -svo /dev/null 'https://vercel.com/' --connect-to vercel.com:443:cname.vercel-dns.com 2>&1 | grep -i '* Connec'
* Connecting to hostname: cname.vercel-dns.com
* Connected to (nil) (76.76.21.142) port 443 (#0)
* Connection #0 to host (nil) left intact

@bagder
Copy link
Member

bagder commented May 12, 2023

Thanks!

@bagder bagder closed this in ac5ad52 May 12, 2023
bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
@smaeda-ks @bch
url: fix null dispname for --connect-to option
0ca33e3 
Closes curl#11106
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@smaeda-ks @bagder