Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do h2 flow window accounting for cancelled streams #11052

Closed
wants to merge 3 commits into from
Closed

Do h2 flow window accounting for cancelled streams #11052

wants to merge 3 commits into from

Conversation

icing
Copy link
Contributor

@icing icing commented Apr 28, 2023

  • nghttp2 does not free connection level window flow for aborted streams
  • when closing transfers, make sure that any buffered response data is "given back" to the flow control window
  • add tests test_02_22 and test_02_23 to reproduce

@icing
Do h2 flow window accounting for cancelled streams
13507eb 
- nghttp2 does not free connection level window flow for
  aborted streams
- when closing transfers, make sure that any buffered
  response data is "given back" to the flow control window
- add tests test_02_22 and test_02_23 to reproduce
@github-actions github-actions bot added the tests label Apr 28, 2023
@icing icing mentioned this pull request Apr 28, 2023
Closed
@bagder bagder added the HTTP/2 label Apr 28, 2023
@bagder
Copy link
Member

bagder commented Apr 28, 2023

Thanks!

@bagder bagder closed this in a9b7f72 Apr 28, 2023
bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
@icing @bch
http2: do flow window accounting for cancelled streams
793afec 
- nghttp2 does not free connection level window flow for
  aborted streams
- when closing transfers, make sure that any buffered
  response data is "given back" to the flow control window
- add tests test_02_22 and test_02_23 to reproduce

Closes curl#11052
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
HTTP/2 tests
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@icing @bagder