Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hostcheck: fix host name wildcard checking #11018

Closed
wants to merge 5 commits into from
Closed

Conversation

bagder
Copy link
Member

@bagder bagder commented Apr 25, 2023

The leftmost "label" only matches against a single '*'. (This is how the browsers work since a long time back)

  • extended unit test 1397 for Curl_cert_hostcheck
  • move some SOURCE variables from unit/Makefile.am to unit/Makefile.inc

Reported-by: Hiroki Kurosawa

@bagder bagder added the TLS label Apr 25, 2023
@github-actions github-actions bot added the tests label Apr 25, 2023
@bagder bagder changed the title hostcheck: fix IDN host name checking hostcheck: fix host name wildcard checking Apr 25, 2023
The leftmost "label" of the host name can now only match against single
'*'. Like the browsers have worked for a long time.

- extended unit test 1397 for this
- move some SOURCE variables from unit/Makefile.am to unit/Makefile.inc

Reported-by: Hiroki Kurosawa
@bagder bagder closed this in 199f2d4 Apr 26, 2023
@bagder bagder deleted the bagder/hostcheck branch April 26, 2023 07:08
bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
The leftmost "label" of the host name can now only match against single
'*'. Like the browsers have worked for a long time.

- extended unit test 1397 for this
- move some SOURCE variables from unit/Makefile.am to unit/Makefile.inc

Reported-by: Hiroki Kurosawa
Closes curl#11018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

1 participant