tests/sshserver.pl: Define AddressFamily earlier #10983
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the comment states "Address family must be specified before ListenAddress", otherwise the tests fail to run `"failed starting SSH server" 52 times (582, 583, 600, 601, 602, 603, 604, 605, 606 and 43 more)`
|
Issue happened due to an ancient version of OpenSSH (v5.1) being used by accident on test system. Installing OpenSSH v9.3 and running the test suite is fine without this proposed change, so it's only needed for backwards compat testing. |
|
@dfandrich I assigned this review to you since you're all over the test scripts these days |
|
Thanks! I've submitted this with an extra no-op line added in a conditional earlier in the file so that this line gets added at exactly the same point in both a Windows and non-Windows config. |
bch
pushed a commit
to bch/curl
that referenced
this pull request
Jul 19, 2023
As the comment states "Address family must be specified before ListenAddress", otherwise the tests fail to run `"failed starting SSH server" 52 times (582, 583, 600, 601, 602, 603, 604, 605, 606 and 43 more)` Closes curl#10983
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the comment states "Address family must be specified before ListenAddress", otherwise the tests fail to run
"failed starting SSH server" 52 times (582, 583, 600, 601, 602, 603, 604, 605, 606 and 43 more)