Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autotools: sync up clang picky warnings with cmake #10974

Closed
wants to merge 4 commits into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Apr 16, 2023

Bringing missing options over from CMake.

Move around existing -Wno-pointer-bool-conversion option to come
after -Wconversion.

Closes #10974

@github-actions github-actions bot added the build label Apr 16, 2023
@vszakats vszakats changed the title autotools: extend clang/gcc picky warnings autotools: sync up clang/gcc picky warnings with cmake Apr 16, 2023
CURL_ADD_COMPILER_WARNINGS([tmp_CFLAGS], [shadow])
CURL_ADD_COMPILER_WARNINGS([tmp_CFLAGS], [unused])
CURL_ADD_COMPILER_WARNINGS([tmp_CFLAGS], [no-multichar])
CURL_ADD_COMPILER_WARNINGS([tmp_CFLAGS], [no-system-headers])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is actually already defined below.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, thanks for spotting them.

Bringing missing options over from CMake.

Closes curl#10974
@vszakats vszakats changed the title autotools: sync up clang/gcc picky warnings with cmake autotools: sync up clang picky warnings with cmake Apr 16, 2023
for failing: macOS / SecureTransport http2 (pull_request)
@vszakats
Copy link
Member Author

This is unrelated and happens also without this patch:

tool_operhlp.c:112:5: warning: Value stored to 'uerr' is never read [deadcode.DeadStores]
    uerr = curl_url_get(uh, CURLUPART_QUERY, &query, 0);
    ^      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.

https://dev.azure.com/daniel0244/curl/_build/results?buildId=15247&view=logs&jobId=e2e9a903-bd95-5516-8620-b8f4e5800a42&j=e2e9a903-bd95-5516-8620-b8f4e5800a42&t=b96a1c9b-30a9-56e9-62cc-d046c220147f

bagder added a commit that referenced this pull request Apr 16, 2023
bagder added a commit that referenced this pull request Apr 17, 2023
@vszakats vszakats closed this in 81c9c8c Apr 17, 2023
@vszakats vszakats deleted the ac-more-picky branch April 17, 2023 11:36
bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
Bringing missing options over from CMake.

Move around existing `-Wno-pointer-bool-conversion` option to come
_after_ `-Wconversion`.

Reviewed-by: Marcel Raad
Closes curl#10974
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants