Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cookie: clarify that init with data set to NULL reads no file #10930

Closed
wants to merge 2 commits into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Apr 11, 2023

... and make Curl_cookie_add() require 'data' being set proper with an assert.

The function has not worked with a NULL data for quite some time so this just corrects the code and comment.

This is a different take than the proposed fixed in #10927

Reported-by: Kvarec Lezki in #10929

@bagder bagder added the cookies label Apr 11, 2023
... and make Curl_cookie_add() require 'data' being set proper with an
assert.

The function has not worked with a NULL data for quite some time so this
just corrects the code and comment.

This is a different take than the proposed fixed in #10927

Reported-by: Kvarec Lezki
Ref: #10929
@bagder bagder closed this in b1b326e Apr 11, 2023
@bagder bagder deleted the bagder/cookie-data-null branch April 11, 2023 21:50
kvarec added a commit to kvarec/curl_fixes that referenced this pull request Apr 12, 2023
Conflicts with fix curl#10930
bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
... and make Curl_cookie_add() require 'data' being set proper with an
assert.

The function has not worked with a NULL data for quite some time so this
just corrects the code and comment.

This is a different take than the proposed fixed in curl#10927

Reported-by: Kvarec Lezki
Ref: curl#10929
Closes curl#10930
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

1 participant