Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: Remove unused Curl_http2_strerror function declaration #10912

Closed
wants to merge 1 commit into from
Closed

http2: Remove unused Curl_http2_strerror function declaration #10912

wants to merge 1 commit into from

Conversation

Biswa96
Copy link
Contributor

@Biswa96 Biswa96 commented Apr 9, 2023 

Curl_http2_strerror was renamed to http2_strerror in 05b100aee247bb9bec8e9a1b0166496aa4248d1c
and then http2_strerror was removed in 5808a0d0f5ea0399d4a2a22285f78c66f302c173

This also fixes the following compiler error

lib/http2.h:41:33: error: unknown type name 'uint32_t'
lib/http2.h:1:1: note: 'uint32_t' is defined in header '<stdint.h>'

@Biswa96
http2: Remove unused Curl_http2_strerror function declaration
a8434f2 
Curl_http2_strerror was renamed to http2_strerror in 05b100a
and then http2_strerror was removed in 5808a0d

This also fixes the following compiler error

lib/http2.h:41:33: error: unknown type name 'uint32_t'
lib/http2.h:1:1: note: 'uint32_t' is defined in header '<stdint.h>'
@Biswa96 Biswa96 mentioned this pull request Apr 9, 2023
Closed
@bagder
Copy link
Member

bagder commented Apr 9, 2023

Thanks!

@bagder bagder closed this in 5023d7c Apr 9, 2023
@Biswa96 Biswa96 deleted the remove-unused-decl branch April 10, 2023 04:11
bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
@Biswa96 @bch
http2: remove unused Curl_http2_strerror function declaration
d97642a 
Curl_http2_strerror was renamed to http2_strerror in
05b100a and then http2_strerror was removed in
5808a0d

This also fixes the following compiler error

lib/http2.h:41:33: error: unknown type name 'uint32_t'
lib/http2.h:1:1: note: 'uint32_t' is defined in header '<stdint.h>'

Closes curl#10912
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
HTTP HTTP/2
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Biswa96 @bagder