Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure: don't set HAVE_WRITABLE_ARGV on Windows #10896

Closed
wants to merge 3 commits into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Apr 6, 2023

Ref: #10888

@bagder bagder added the build label Apr 6, 2023
@bagder
Copy link
Member Author

bagder commented Apr 6, 2023

I can't spot this check being done in cmake at all... 😮

@bagder bagder added the cmake label Apr 6, 2023
@bagder
Copy link
Member Author

bagder commented Apr 6, 2023

It says Unknown CMake command "check_c_source_runs".

But https://cmake.org/cmake/help/v3.0/module/CheckCSourceRuns.html ?

Can any cmake person tell me what I do wrong?

@bagder
Copy link
Member Author

bagder commented Apr 6, 2023

thanks @jzakrzewski !

@bagder bagder closed this in 7b95b6e Apr 6, 2023
bagder added a commit that referenced this pull request Apr 6, 2023
Assisted-by: Jakub Zakrzewski
Closes #10896
@bagder bagder deleted the bagder/configure-win-argv branch April 6, 2023 21:53
bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
Assisted-by: Jakub Zakrzewski
Closes curl#10896
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants