Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dynbuf: never allocate larger than "toobig" #10845

Closed
wants to merge 1 commit into from
Closed

dynbuf: never allocate larger than "toobig" #10845

wants to merge 1 commit into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Mar 27, 2023

As dynbufs always have a fixed maximum size which they are not allowed to grow larger than, making sure that it never allocates a larger buffer makes sure the buffer does not allocate memory that will never be used.

@bagder
dynbuf: never allocate larger than "toobig"
7dfc926 
As dynbufs always have a fixed maximum size which they are not allowed
to grow larger than, making sure that it never allocates a larger buffer
makes sure the buffer does not allocate memory that will never be used.
@bagder bagder added the tidy-up label Mar 27, 2023
@bagder bagder closed this in 5a10f48 Mar 28, 2023
@bagder bagder deleted the bagder/dynbuf-trim-alloc branch March 28, 2023 08:24
bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
@bagder @bch
dynbuf: never allocate larger than "toobig"
8b24ec7 
As dynbufs always have a fixed maximum size which they are not allowed
to grow larger than, making sure that it never allocates a larger buffer
makes sure the buffer does not allocate memory that will never be used.

Closes curl#10845
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jay jay jay approved these changes

Assignees
No one assigned
Labels
tidy-up
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bagder @jay