Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtsp: skip the malformed RTSP interleaved frame data #10808

Closed
wants to merge 7 commits into from

Conversation

dengjfzh
Copy link
Contributor

Some IP camera send malformed RTSP interleaved frames sometimes, which can cause curl_easy_perform return 1 (CURLE_UNSUPPORTED_PROTOCOL).
This commit attempts to skip clearly incorrect RTSP interleaving frame data.

@github-actions github-actions bot added the tests label Mar 21, 2023
@vszakats vszakats added RTSP and removed tests labels Mar 21, 2023
@vszakats vszakats changed the title rtsp:skip the malformed RTSP interleaved frame data rtsp: skip the malformed RTSP interleaved frame data Mar 21, 2023
@bagder
Copy link
Member

bagder commented Mar 21, 2023

This change seems to have broken test 3100

Some IP camera send malformed RTSP interleaved frames sometimes, which can
cause curl_easy_perform return 1 (CURLE_UNSUPPORTED_PROTOCOL).
This commit attempts to skip clearly incorrect RTSP interleaving frame data.
@dengjfzh dengjfzh force-pushed the skip_invalid_interleaved_data branch from 2473e71 to 16dc9f3 Compare March 21, 2023 14:08
@github-actions github-actions bot added the tests label Mar 21, 2023
@dengjfzh
Copy link
Contributor Author

This change seems to have broken test 3100

Has been fixed.

lib/urldata.h Show resolved Hide resolved
lib/rtsp.c Outdated Show resolved Hide resolved
lib/rtsp.c Show resolved Hide resolved
lib/rtsp.c Show resolved Hide resolved
lib/rtsp.c Outdated Show resolved Hide resolved
lib/rtsp.c Outdated Show resolved Hide resolved
lib/rtsp.c Outdated Show resolved Hide resolved
lib/rtsp.c Outdated Show resolved Hide resolved
lib/rtsp.c Show resolved Hide resolved
lib/rtsp.c Outdated Show resolved Hide resolved
lib/rtsp.c Show resolved Hide resolved
lib/rtsp.c Show resolved Hide resolved
lib/rtsp.c Show resolved Hide resolved
lib/rtsp.c Show resolved Hide resolved
lib/rtsp.c Show resolved Hide resolved
lib/urldata.h Show resolved Hide resolved
@bagder
Copy link
Member

bagder commented Mar 30, 2023

Thanks!

@bagder bagder closed this in 6c6306f Mar 30, 2023
bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
Some IP cameras send malformed RTSP interleaved frames sometimes, which
can cause curl_easy_perform return 1 (CURLE_UNSUPPORTED_PROTOCOL).  This
change attempts to skip clearly incorrect RTSP interleaving frame data.

Closes curl#10808
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants