Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

socket recv buffering #10787

Closed
wants to merge 2 commits into from
Closed

socket recv buffering #10787

wants to merge 2 commits into from

Conversation

icing
Copy link
Contributor

@icing icing commented Mar 17, 2023

Adding socket recv buffering for most tcp cases

  • use bufq as recv buffer, also for Windows pre-receive handling
  • tweak bufq to properly handle some edge cases found

@github-actions github-actions bot added the tests label Mar 17, 2023
@icing icing requested a review from jay April 3, 2023 08:26
@icing
Copy link
Contributor Author

icing commented Apr 3, 2023

@jay: this touches on the pre-receive windows stuff. I'd like to hear your opinion on this!

@icing
Adding socket recv buffering for most tcp cases
a85e381 
- use bufq as recv buffer, also for Windows pre-receive handling
- catch small reads followed by larger ones in a single socket
  call. A common pattern on TLS connections.
@icing
Make test_12_01 a bit more forgiving on connection counts
b06846d
@bagder bagder closed this in 24726a4 Apr 13, 2023
@bagder
Copy link
Member

bagder commented Apr 13, 2023

Thanks!

bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
@icing @bch
cf-socket: add socket recv buffering for most tcp cases
565365c 
- use bufq as recv buffer, also for Windows pre-receive handling
- catch small reads followed by larger ones in a single socket
  call. A common pattern on TLS connections.

Closes curl#10787
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jay jay Awaiting requested review from jay

Assignees
No one assigned
Labels
connecting & proxies tests
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@icing @bagder