Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtsp: convert mallocs to dynbuf for RTP buffering #10786

Closed
wants to merge 1 commit into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Mar 17, 2023

This is take two, first shot was in #10776

@bagder bagder added feature-window A merge of this requires an open feature window RTSP labels Mar 17, 2023
bagder added a commit that referenced this pull request Mar 22, 2023
@bagder bagder removed the feature-window A merge of this requires an open feature window label Mar 30, 2023
@bagder
Copy link
Member Author

bagder commented Mar 30, 2023

After this PR, we are down to just 13 realloc() calls left in libcurl:

$ git grep '= \(Curl_safe\|\)realloc(' 
content_encoding.c:    z->next_in = Curl_saferealloc(z->next_in, z->avail_in);
dynbuf.c:    void *p = realloc(s->bufr, a);
getenv.c:    tmp = realloc(buf, rc);
headers.c:  newhs = Curl_saferealloc(hs, sizeof(*hs) + vlen + oalloc + 1);
http2.c:      headp = Curl_saferealloc(stream->push_headers,
krb5.c:      buf->data = Curl_saferealloc(buf->data, len);
krb5.c:  tmp_allocation = realloc(conn->app_data, mech->size);
strdup.c:  void *datap = realloc(ptr, size);
vtls/bearssl.c:        new_anchors = realloc(ca.anchors,
vtls/openssl.c:              void *tmp = realloc(enhkey_usage, req_size);
vtls/schannel.c:    reallocated_buffer = realloc(backend->encdata_buffer,
vtls/schannel.c:      reallocated_buffer = realloc(backend->encdata_buffer,
vtls/schannel.c:          reallocated_buffer = realloc(backend->decdata_buffer,

@bagder bagder closed this in 4399a53 Apr 4, 2023
@bagder bagder deleted the bagder/rtsp-take2 branch June 5, 2023 10:45
bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

1 participant