haproxy: add --haproxy-clientip flag to spoof client IPs #10779
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaitoBezarius
force-pushed
the
haproxy-client-ip
branch
from
ed3cb80
to
4a4cd5a
Compare
bagder
added
needs-info
and removed
feature-window
RaitoBezarius
force-pushed
the
haproxy-client-ip
branch
from
4a4cd5a
to
0872d61
Compare
RaitoBezarius
force-pushed
the
haproxy-client-ip
branch
from
0872d61
to
1a7ef3d
Compare
|
@bagder Hi there, I updated the PR and added some test cases, is there anything else to do so the contribution can be accepted? |
|
(I see that my tests needs to be fixed too.) |
RaitoBezarius
force-pushed
the
haproxy-client-ip
branch
from
1a7ef3d
to
f5abf6a
Compare
|
The test 1912 problem can be fixed with this: diff --git a/include/curl/typecheck-gcc.h b/include/curl/typecheck-gcc.h
index bc8d7a78c..b880f3dc6 100644
--- a/include/curl/typecheck-gcc.h
+++ b/include/curl/typecheck-gcc.h
@@ -278,10 +278,11 @@ CURLWARNING(_curl_easy_getinfo_err_curl_off_t,
(option) == CURLOPT_EGDSOCKET || \
(option) == CURLOPT_FTP_ACCOUNT || \
(option) == CURLOPT_FTP_ALTERNATIVE_TO_USER || \
(option) == CURLOPT_FTPPORT || \
(option) == CURLOPT_HSTS || \
+ (option) == CURLOPT_HAPROXY_CLIENT_IP || \
(option) == CURLOPT_INTERFACE || \
(option) == CURLOPT_ISSUERCERT || \
(option) == CURLOPT_KEYPASSWD || \
(option) == CURLOPT_KRBLEVEL || \
(option) == CURLOPT_LOGIN_OPTIONS || \ |
|
The 1139 test failure happens because you have not created a |
bagder
reviewed
May 9, 2023
RaitoBezarius
force-pushed
the
haproxy-client-ip
branch
from
f5abf6a
to
e1375e6
Compare
|
Thank you for the guidance, I have fixed the remaining issues, I am checking the CI on my side but hopefully should be good. |
RaitoBezarius
force-pushed
the
haproxy-client-ip
branch
from
e1375e6
to
55bf56b
Compare
|
Hmm, it's unclear to me why 3201/3022 are failing now. Testing manually seems to work. |
RaitoBezarius
force-pushed
the
haproxy-client-ip
branch
2 times, most recently
from
65f837b
to
2835f34
Compare
bagder
added
feature-window
bagder
reviewed
May 14, 2023
RaitoBezarius
force-pushed
the
haproxy-client-ip
branch
2 times, most recently
from
1a31724
to
cfa44f1
Compare
|
@bagder I addressed the comments, rebased the PR, let me know if I can do anything more. :) |
RaitoBezarius
force-pushed
the
haproxy-client-ip
branch
from
cfa44f1
to
eb677ab
Compare
RaitoBezarius
force-pushed
the
haproxy-client-ip
branch
2 times, most recently
from
33be06a
to
b433705
Compare
RaitoBezarius
force-pushed
the
haproxy-client-ip
branch
from
b433705
to
0921fa8
Compare
|
Thanks! |
bch
pushed a commit
to bch/curl
that referenced
this pull request
Jul 19, 2023
CURLOPT_HAPROXY_CLIENT_IP in the library Closes curl#10779
ptitSeb
pushed a commit
to wasix-org/curl
that referenced
this pull request
Sep 25, 2023
CURLOPT_HAPROXY_CLIENT_IP in the library Closes curl#10779
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enable
--haproxy-clientipas per TODO item 5.2 (#5125).I'm not certain yet I have done the appropriate things yet. I will add tests and docs soon. :)