HTTP/2 flow control and buffer improvements #10771
Closed
+707
−737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icing
force-pushed
the
h2+bufq
branch
2 times, most recently
from
ca0d3ed to
8058b1e
Compare
Closed
icing
force-pushed
the
h2+bufq
branch
2 times, most recently
from
4127ee4 to
c36bd0d
Compare
- use bufq for send/receive of network data - usd bufq for send/receive of stream data - use HTTP/2 flow control with no-auto updates to control the amount of data we are buffering for a stream HTTP/2 stream window set to 128K after local tests, defined code constant for now - elminiating PAUSEing nghttp2 processing when receiving data since a stream can now take in all DATA nghttp2 forwards Improved scorecard and adjuste http2 stream window sizes - scorecard improved output formatting and options default - scorecard now also benchmarks small requests / second
|
Thanks! |
|
Am 31.03.2023 um 04:29 schrieb Dan Fandrich ***@***.***>:
It looks like is causing test failures in rustls builds with
FAILED tests/http/test_07_upload.py::TestUpload::test_07_12_upload_seq_large[0-h2] - AssertionError: expected exit code 0, got 26
e.g. see here or here.
Interesting, will investigate.
… —
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Am 31.03.2023 um 08:56 schrieb Stefan Eissing ***@***.***>:
> Am 31.03.2023 um 04:29 schrieb Dan Fandrich ***@***.***>:
>
>
> It looks like is causing test failures in rustls builds with
> FAILED tests/http/test_07_upload.py::TestUpload::test_07_12_upload_seq_large[0-h2] - AssertionError: expected exit code 0, got 26
> e.g. see here or here.
Interesting, will investigate.
Ok, rustls returns IOERROR if its internal plaintext buffer is full. Hmm....
…
> —
> Reply to this email directly, view it on GitHub, or unsubscribe.
> You are receiving this because you authored the thread.Message ID: ***@***.***>
|
bch
pushed a commit
to bch/curl
that referenced
this pull request
Jul 19, 2023
- use bufq for send/receive of network data - usd bufq for send/receive of stream data - use HTTP/2 flow control with no-auto updates to control the amount of data we are buffering for a stream HTTP/2 stream window set to 128K after local tests, defined code constant for now - elminiating PAUSEing nghttp2 processing when receiving data since a stream can now take in all DATA nghttp2 forwards Improved scorecard and adjuste http2 stream window sizes - scorecard improved output formatting and options default - scorecard now also benchmarks small requests / second Closes curl#10771
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #10720