Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test2305 (websocket) doesn't handle CURLE_AGAIN #10760

Closed
jay opened this issue Mar 14, 2023 · 0 comments
Closed

test2305 (websocket) doesn't handle CURLE_AGAIN #10760

jay opened this issue Mar 14, 2023 · 0 comments
Labels
tests WebSocket

Comments

@jay
Copy link
Member

jay commented Mar 14, 2023

I did this

CI test fails in 2305 likely due to "curl_ws_recv returned 81" (81 == CURLE_AGAIN).

curl/tests/libtest/lib2305.c

Lines 50 to 65 in 06f65f7

/* Three 4097-bytes frames are expected, 12291 bytes */
while(i < 12291) {
CURLcode result =
curl_ws_recv(curl, buffer, sizeof(buffer), &nread, &meta);
if(result) {
printf("curl_ws_recv returned %d\n", (int)result);
return;
}
printf("%u: nread %u Age %u Flags %x "
"Offset %" CURL_FORMAT_CURL_OFF_T " "
"Bytesleft %" CURL_FORMAT_CURL_OFF_T "\n",
(int)i,
nread, meta->age, meta->flags, meta->offset, meta->bytesleft);
i += meta->len;
fwrite(buffer, 1, nread, save);
}

I expected the following

It is not documented that curl_ws_recv / send returns CURLE_AGAIN. I assume curl_ws_xxx is much like regular curl_easy_xxx send/recv?
bagder added a commit that referenced this issue Mar 16, 2023
@bagder
lib2305: deal with CURLE_AGAIN
96847df 
The test does a slightly ugly busy-loop for this case but should be
managable due to it likely being a very short moment.

Mention CURLE_AGAIN in curl_ws_recv.3

Fixes #10760
Reported-by: Jay Satiro
@bagder bagder mentioned this issue Mar 16, 2023
Closed
@bagder bagder closed this as completed in f24014c Mar 16, 2023
bch pushed a commit to bch/curl that referenced this issue Jul 19, 2023
@bagder @bch
lib2305: deal with CURLE_AGAIN
1b38183 
The test does a slightly ugly busy-loop for this case but should be
managable due to it likely being a very short moment.

Mention CURLE_AGAIN in curl_ws_recv.3

Fixes curl#10760
Reported-by: Jay Satiro
Closes curl#10781
@untitaker untitaker mentioned this issue Apr 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests WebSocket
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

lib2305: deal with CURLE_AGAIN curl/curl
1 participant
@jay