multi: make multi_perform ignore/unignore signals less often #10750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
too simple approach, need to rethink |
looks fine, what am i missing? |
|
Each easy handle has its own |
bagder
force-pushed
the
bagder/multi-perform-ignore
branch
from
69a2962
to
087c6bd
Compare
bagder
added a commit
that referenced
this pull request
Apr 27, 2023
The multi-ignore logic that previously applied to curl_multi_perform() (#10750) is here applied to the loop within curl_multi_socket_action() to make it use the same optimization: most handles have the same signal-ignore option state so this drastically reduces the number of ignore/unignore calls per libcurl function invoke. Follow-up to bc90308
bagder
added a commit
that referenced
this pull request
Apr 27, 2023
The multi-ignore logic that was previously applied to curl_multi_perform() (#10750) is here applied to the loop within curl_multi_socket_action() to make it use the same optimization: most handles have the same signal-ignore option state so this drastically reduces the number of ignore/unignore calls per libcurl function invoke. Follow-up to bc90308
bagder
added a commit
that referenced
this pull request
Apr 28, 2023
The multi-ignore logic that was previously applied to curl_multi_perform() (#10750) is here applied to the loop within curl_multi_socket_action() to make it use the same optimization: most handles have the same signal-ignore option state so this drastically reduces the number of ignore/unignore calls per libcurl function invoke. Follow-up to bc90308 Closes #11045
bch
pushed a commit
to bch/curl
that referenced
this pull request
Jul 19, 2023
For improved performance Reported-by: Jerome St-Louis Ref: curl#10743 Closes curl#10750
bch
pushed a commit
to bch/curl
that referenced
this pull request
Jul 19, 2023
The multi-ignore logic that was previously applied to curl_multi_perform() (curl#10750) is here applied to the loop within curl_multi_socket_action() to make it use the same optimization: most handles have the same signal-ignore option state so this drastically reduces the number of ignore/unignore calls per libcurl function invoke. Follow-up to bc90308 Closes curl#11045
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #10743