Hack to build most unit tests under cmake #10722
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Put only the test names into Makefile.inc so they can be used by both cmake and automake. This will prevent the list of tests from becoming out of date when they are also built under cmake.
There's no need to specify them individually.
dfandrich
force-pushed
the
dfandrich/unitcmake
branch
from
93dc6f9
to
b186ecf
Compare
dfandrich
added a commit
that referenced
this pull request
Mar 9, 2023
These are only built when a libcurl static library is available, since we're not building a special libcurlu library yet and these tests rely on private symbols that aren't available in the shared library. A few unit tests do require libcurlu, so those are not built. Closes #10722
dfandrich
force-pushed
the
dfandrich/unitcmake
branch
from
b186ecf
to
aa176af
Compare
dfandrich
added a commit
that referenced
this pull request
Mar 9, 2023
These are only built when a libcurl static library is available, since we're not building a special libcurlu library yet and these tests rely on private symbols that aren't available in the shared library. A few unit tests do require libcurlu, so those are not built. Closes #10722
dfandrich
force-pushed
the
dfandrich/unitcmake
branch
from
aa176af
to
7b191cd
Compare
Switch unit1654 to use the proper test macros as well.
These are only built when a libcurl static library is available, since we're not building a special libcurlu library yet and these tests rely on private symbols that aren't available in the shared library. A few unit tests do require libcurlu, so those are not built. Closes #10722
dfandrich
force-pushed
the
dfandrich/unitcmake
branch
from
7b191cd
to
40dd5f4
Compare
bch
pushed a commit
to bch/curl
that referenced
this pull request
Jul 19, 2023
These are only built when a libcurl static library is available, since we're not building a special libcurlu library yet and these tests rely on private symbols that aren't available in the shared library. A few unit tests do require libcurlu, so those are not built. Closes curl#10722
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The results should be visible in the Appveyor Debug Static builds