Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

urlapi: '%' is illegal in host names #10711

Closed
wants to merge 1 commit into from
Closed

Conversation

bagder
Copy link
Member

@bagder bagder commented Mar 8, 2023

Update test 1560 to verify

Ref: #10708

Update test 1560 to verify

Ref: #10708
@bagder bagder added the URL label Mar 8, 2023
@bagder bagder closed this in 0a0c9b6 Mar 8, 2023
@bagder bagder deleted the bagder/percent-hostnames branch March 8, 2023 14:34
@rcombs
Copy link
Contributor

rcombs commented Mar 8, 2023

Percent signs in the host field can be desirable for e.g. IPv6 address literals: on some platforms, link-local addresses may be followed by %[interface] as an extension, e.g. curl http://[fe80::…%en0]/ works in the current version on macOS and FreeBSD.

@bagder
Copy link
Member Author

bagder commented Mar 8, 2023

That's not in a host name though, that's in an IPv6 address and we have tests verifying that to work fine still.

You can also use percent-encoding om host names and then percents are also present and that too is fine.

@bagder
Copy link
Member Author

bagder commented Mar 8, 2023

btw, the %-thing in IPv6 addresses is called "zone id" in the URL API

@rcombs
Copy link
Contributor

rcombs commented Mar 8, 2023

Ah, neat! Okay, sounds reasonable then.

bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
Update test 1560 to verify

Ref: curl#10708
Closes curl#10711
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants