Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile.mk: delete redundant HAVE_LDAP_SSL macro [ci skip] #10681

Closed
wants to merge 1 commit into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Mar 5, 2023

Since abebb2b, we set this macro for all Windows wldap32 builds using Makefile.mk.

For OpenLDAP builds this macro is not enough to enable LDAPS, and OpenLDAP is not an option in Makefile.mk. For Novell LDAP it might have helped, but it's also not an option anymore in Makefile.mk.

The future for LDAPS is that we should enable it by default without extra build knobs.

Closes #10681

Since abebb2b, we set this macro for
all Windows `wldap32` builds using `Makefile.mk`.

For OpenLDAP builds this macro is not enough to enable LDAPS, and
OpenLDAP is not an option in `Makefile.mk`. For Novell LDAP it might
have helped, but it's also not an option anymore in `Makefile.mk`.

Either way the future for LDAPS is that we should enable them by
default without extra build knobs.
@vszakats vszakats changed the title Makefile.mk: delete redundant HAVE_LDAP_SSL macro [ci skip] Makefile.mk: delete redundant HAVE_LDAP_SSL macro [ci skip] Mar 5, 2023
@vszakats vszakats closed this in 8d0fa3a Mar 5, 2023
@vszakats vszakats deleted the mk-del-dupe-ldaps-macro branch March 5, 2023 19:53
vszakats added a commit to curl/curl-for-win that referenced this pull request Mar 7, 2023
This has been the default since this curl commit:
curl/curl@abebb2b

Upcoming curl 8.0.0 will ignore the `-ldaps` option:
curl/curl@8d0fa3a
curl/curl#10681
bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
Since abebb2b, we set this macro for
all Windows `wldap32` builds using `Makefile.mk`.

For OpenLDAP builds this macro is not enough to enable LDAPS, and
OpenLDAP is not an option in `Makefile.mk`. For Novell LDAP it might
have helped, but it's also not an option anymore in `Makefile.mk`.

The future for LDAPS is that we should enable it by default without
extra build knobs.

Reviewed-by: Marcel Raad
Closes curl#10681
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants