Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

time_connect is 0 when error on 7.88.0/7.88.1 #10670

Closed
masterinspire opened this issue Mar 3, 2023 · 1 comment
Closed

time_connect is 0 when error on 7.88.0/7.88.1 #10670

masterinspire opened this issue Mar 3, 2023 · 1 comment
Assignees
@icing
Labels
connecting & proxies

Comments

@masterinspire
Copy link

masterinspire commented Mar 3, 2023 •
edited

time_connect is 0 when error

I did this

I can connect to 1.1.1.1:

curl "https://1.1.1.1" --output nul --write-out "%{time_connect}" --no-progress-meter -slient

time_connect here is > 0.

Deliberately point example.com to 1.1.1.1 to cause a ssl error:

curl "https://example.com" --output nul --write-out "%{time_connect}" --no-progress-meter --resolve "example.com:443:1.1.1.1" -slient

time_connect here is 0.000000 on 7.88, > 0 on 7.87.

image

I expected the following

time_connect > 0.

curl/libcurl version

curl 7.88.1 (x86_64-w64-mingw32) libcurl/7.88.1 OpenSSL/3.0.8 (Schannel) zlib/1.2.13 brotli/1.0.9 zstd/1.5.4 WinIDN libssh2/1.10.0 nghttp2/1.52.0 ngtcp2/0.13.1 nghttp3/0.8.0 libgsasl/2.2.0
Release-Date: 2023-02-20
Protocols: dict file ftp ftps gopher gophers http https imap imaps ldap ldaps mqtt pop3 pop3s rtsp scp sftp smb smbs smtp smtps telnet tftp ws wss
Features: alt-svc AsynchDNS brotli gsasl HSTS HTTP2 HTTP3 HTTPS-proxy IDN IPv6 Kerberos Largefile libz MultiSSL NTLM SPNEGO SSL SSPI threadsafe TLS-SRP UnixSockets zstd

operating system

Microsoft Windows [Version 10.0.19045.2673]
icing added a commit to icing/curl that referenced this issue Mar 3, 2023
@icing
Fix time_connect and time_appconnect timer statistics
323aff9 
- time_connect was not updated when the overall connection failed,
  e.g. when SSL verification was unsuccessful, refs curl#10670
- rework gather those values to interrogate involved filters,
  also from all eyeballing attempts, to report the maximum of
  those values.
- added 3 test cases in test_06 to check reported values on
  successful, partially failed and totally failed connections.
@icing icing mentioned this issue Mar 3, 2023
Closed
@icing
Copy link
Contributor

icing commented Mar 3, 2023

Thanks for the report. I made a fix in #10671, including test cases. But if you could verify this in your settings as well, that would be much appreciated.

@icing icing self-assigned this Mar 3, 2023
@bagder bagder closed this as completed in 2574160 Mar 6, 2023
bch pushed a commit to bch/curl that referenced this issue Jul 19, 2023
@icing @bch
connect: fix time_connect and time_appconnect timer statistics
d11c516 
- time_connect was not updated when the overall connection failed,
  e.g. when SSL verification was unsuccessful, refs curl#10670
- rework gather those values to interrogate involved filters,
  also from all eyeballing attempts, to report the maximum of
  those values.
- added 3 test cases in test_06 to check reported values on
  successful, partially failed and totally failed connections.

Reported-by: Master Inspire
Fixes curl#10670
Closes curl#10671
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@icing icing

Labels
connecting & proxies
Milestone
No milestone
Development

No branches or pull requests
3 participants
@icing @bagder @masterinspire