Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYNBUF.md: note Curl_dyn_add* calls Curl_dyn_free on failure #10645

Closed
wants to merge 1 commit into from

Conversation

jay
Copy link
Member

@jay jay commented Mar 1, 2023

This is the existing behavior and it has been widely assumed in the codebase.

Closes #xxxx

@jay
Copy link
Member Author

jay commented Mar 1, 2023

The spellcheck CI is failing due to the word 'dyn' but I didn't add that word and I don't see where it is in the document. 'dynbuf' is already in the list of allowed words.

@bagder
Copy link
Member

bagder commented Mar 1, 2023

I think it is because "Curl_dyn_free" is used without backticks. Write it like Curl_dyn_free instead.

This is the existing behavior and it has been widely assumed in the
codebase.

Closes #xxxx
@jay jay closed this in d36c632 Mar 1, 2023
@jay jay deleted the dynbuf_doc_add branch March 1, 2023 09:19
bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
This is the existing behavior and it has been widely assumed in the
codebase.

Closes curl#10645
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants