Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sectransp: make read_cert() use a dynbuf when loading #10632

Closed
wants to merge 3 commits into from
Closed

sectransp: make read_cert() use a dynbuf when loading #10632

wants to merge 3 commits into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Feb 27, 2023

No description provided.

@bagder bagder added the TLS label Feb 27, 2023
@bagder bagder mentioned this pull request Feb 27, 2023
Closed
@piru
Copy link

piru commented Feb 27, 2023

Using dynbuf makes more sense, indeed.

jay
jay reviewed Mar 1, 2023
View reviewed changes
lib/vtls/sectransp.c
return -1;
}
else if(n == 0) {
if(Curl_dyn_addn(&certs, buf, n)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#10645

@bagder bagder closed this in c50a6ee Mar 1, 2023
@bagder bagder deleted the bagder/sectransp-dynbuf branch March 1, 2023 08:43
bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
@bagder @bch
sectransp: make read_cert() use a dynbuf when loading
a32e1b3 
Closes curl#10632
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jay jay jay left review comments

Assignees
No one assigned
Labels
TLS
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bagder @piru @jay