Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hostip: avoid sscanf #10601

Closed
wants to merge 5 commits into from
Closed

hostip: avoid sscanf #10601

wants to merge 5 commits into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Feb 24, 2023

No description provided.

github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 24, 2023
View reviewed changes
lib/hostip.c Fixed Show fixed Hide fixed
lib/hostip.c Fixed Show fixed Hide fixed
@bagder
Copy link
Member Author

bagder commented Feb 25, 2023

The Microsoft C++ Code Analysis job sounds like it runs into some rate limit:

Error: Code Scanning could not process the submitted SARIF file:
rejecting SARIF, as there are more runs than allowed (1236 > 20)
Error: Code Scanning could not process the submitted SARIF file:
rejecting SARIF, as there are more runs than allowed (1236 > 20)

github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 25, 2023
View reviewed changes
lib/hostip.c Fixed Show fixed Hide fixed
@bagder bagder closed this in 788c6b3 Feb 27, 2023
@bagder bagder deleted the bagder/hostip-sscanf branch February 27, 2023 19:44
bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
@bagder @bch
hostip: avoid sscanf and extra buffer copies
148e91a 
Also made create_hostcache_id() return the id length.

Closes curl#10601
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@bagder