Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-openssl.bat: keep OpenSSL 3.0 engine binaries #10542

Closed
wants to merge 1 commit into from

Conversation

jay
Copy link
Member

@jay jay commented Feb 17, 2023

  • Fix name of OpenSSL 3 engines temp build output folder.

OpenSSL 1.1.x engines temp build output folder name is engines-1_1.
OpenSSL 3.x.x engines temp build output folder name is engines-3.

Prior to this change the engines-1_1 name was erroneously used for OpenSSL 3.

Closes #xxxx

- Fix name of OpenSSL 3 engines temp build output folder.

OpenSSL 1.1.x engines temp build output folder name is engines-1_1.
OpenSSL 3.x.x engines temp build output folder name is engines-3.

Prior to this change the engines-1_1 name was erroneously used for
OpenSSL 3.

Closes #xxxx
@jay jay added the Windows Windows-specific label Feb 17, 2023
@github-actions github-actions bot added the build label Feb 17, 2023
@jay jay closed this in 65d751d Feb 19, 2023
@jay jay deleted the projects_ossl3_engines branch February 19, 2023 00:04
bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
Prior to this change copying the OpenSSL 3 engine binaries failed
because 'engines-1_1' (OpenSSL 1.1.x folder name) was erroneously used
instead of 'engines-3'. The OpenSSL 3 builds would complete successfully
but without the engine binaries.

Closes curl#10542
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Windows Windows-specific
Development

Successfully merging this pull request may close these issues.

None yet

1 participant