Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http2: set drain on stream end #10530

Closed
wants to merge 1 commit into from
Closed

http2: set drain on stream end #10530

wants to merge 1 commit into from

Conversation

piru
Copy link

@piru piru commented Feb 16, 2023

Ensure that on_frame_recv() stream end will trigger a read if there is pending data. Without this it could happen that the pending data is never consumed.

This combined with #10529 should fix #10525

Ref: #10525

Ensure that on_frame_recv() stream end will trigger a read if there is
pending data. Without this it could happen that the pending data is
never consumed.

This combined with #10529 should fix
#10525

Ref: #10525
Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@icing
Copy link
Contributor

icing commented Feb 16, 2023

Nice catch!

@bagder bagder closed this in 87ed650 Feb 16, 2023
@bagder
Copy link
Member

bagder commented Feb 16, 2023

Thanks!

@piru piru deleted the fix-http2-recv-truncate branch February 16, 2023 09:07
bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
Ensure that on_frame_recv() stream end will trigger a read if there is
pending data. Without this it could happen that the pending data is
never consumed.

This combined with curl#10529 should fix
curl#10525

Ref: curl#10525
Closes curl#10530
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

7.88.0 HTTP/2 (multiplexing?) data corruption
3 participants