Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build fix: include stdint.h more readily #10516

Closed
wants to merge 1 commit into from
Closed

build fix: include stdint.h more readily #10516

wants to merge 1 commit into from

Conversation

piru
Copy link

@piru piru commented Feb 15, 2023

stdin.h is needed for uint_t etc types, and stdint.h wasn't included when needed.

@github-actions github-actions bot added the HTTP label Feb 15, 2023
@vszakats vszakats added build HTTP/2 HTTP/3 h3 or quic related and removed HTTP labels Feb 15, 2023
lib/http.h Outdated
@@ -42,7 +42,7 @@ typedef enum {

#ifndef CURL_DISABLE_HTTP

#if defined(_WIN32) && (defined(ENABLE_QUIC) || defined(USE_NGHTTP2))
#if defined(ENABLE_QUIC) || defined(USE_NGHTTP2) || defined(USE_MSH3)

This comment was marked as outdated.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh, no. I misread. It can be made to this:

#if defined(ENABLE_QUIC) || defined(USE_NGHTTP2) 

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't that break with USE_MSH3 section here

curl/lib/http.h

Line 271 in f1d0923

#ifdef USE_MSH3
?

Or is there some implicit dependency between USE_MSH3 and ENABLE_QUIC || USE_NGHTTP2?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

building with any quic backend will define ENABLE_QUIC , so checking extra for USE_MSH3 isn't necessary

@github-actions github-actions bot added the HTTP label Feb 16, 2023
@bagder bagder closed this in 8c93945 Feb 16, 2023
@bagder
Copy link
Member

bagder commented Feb 16, 2023

Thanks!

bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants