Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test2600: try to detect correctly when ALARM_TIMEOUT is in use and ad… #10513

Closed
wants to merge 2 commits into from
Closed

test2600: try to detect correctly when ALARM_TIMEOUT is in use and ad… #10513

wants to merge 2 commits into from

Conversation

icing
Copy link
Contributor

@icing icing commented Feb 14, 2023

…just for it.

  • use higher timeout values > 1s
  • skip duration checks

@github-actions github-actions bot added the tests label Feb 14, 2023
@icing icing mentioned this pull request Feb 14, 2023
Closed
MarcelRaad
MarcelRaad reviewed Feb 15, 2023
View reviewed changes
tests/unit/unit2600.c
@@ -223,6 +256,7 @@ static void check_result(struct test_case *tc,
tc->id, tc->exp_cf6_creations, tr->cf6.creations);
fail(msg);
}
#ifndef USE_ALARM_TIMEOUT
duration_ms = Curl_timediff(tr->ended, tr->started);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GCC now complains that duration_ms is unused in the USE_ALARM_TIMEOUT case.

@icing
test2600: try to detect correctly when ALARM_TIMEOUT is in use and ad…
7fb813f 
…just for it.

- use higher timeout values > 1s
- skip duration checks
MarcelRaad
MarcelRaad approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@MarcelRaad MarcelRaad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me now on Solaris 11, thanks a lot! 👍

@bagder
Copy link
Member

bagder commented Feb 22, 2023

Thanks, both of you!

@bagder bagder closed this in 463158b Feb 22, 2023
bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
@icing @bch
test2600: detect when ALARM_TIMEOUT is in use and adjust
407d59f 
- use higher timeout values > 1s
- skip duration checks

Assisted-by: Marcel Raad
Closes curl#10513
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcelRaad MarcelRaad MarcelRaad approved these changes

Assignees
No one assigned
Labels
tests
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@icing @bagder @MarcelRaad