Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the test telnet server shut down a socket gracefully #10509

Closed
wants to merge 1 commit into from
Closed

Make the test telnet server shut down a socket gracefully #10509

wants to merge 1 commit into from

Conversation

icing
Copy link
Contributor

@icing icing commented Feb 14, 2023

  • test 1452 failed occasionally with ECONNRESET errnos in curl when the server closed the connection in an unclean state.
  • changed server shutdown to make a final recv() with short timeout before shutting down the socket

@icing
Another attempt to make the test telnet server shut down a socket gra…
2a4abf8 
…cefully.

- test 1452 failed occasionally with ECONNRESET errnos in curl when the
  server closed the connection in an unclean state.
@github-actions github-actions bot added the tests label Feb 14, 2023
@bagder
Copy link
Member

bagder commented Feb 14, 2023

✔️ wow, all green! 💚 💚 💚

@bagder
Copy link
Member

bagder commented Feb 16, 2023

Thanks!

@bagder bagder closed this in 79d0b3c Feb 16, 2023
bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
@icing @bch
tests: make the telnet server shut down a socket gracefully
0a28e01 
- test 1452 failed occasionally with ECONNRESET errnos in curl when the
  server closed the connection in an unclean state.

Closes curl#10509
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tests
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@icing @bagder