Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Brotli name #10471

Closed
wants to merge 1 commit into from
Closed

Fix Brotli name #10471

wants to merge 1 commit into from

Conversation

data-man
Copy link
Contributor

For avoiding CMake's warning:

CMake Warning (dev) at /usr/share/cmake-3.25/Modules/FindPackageHandleStandardArgs.cmake:438 (message):
The package name passed to find_package_handle_standard_args (BROTLI)
does not match the name of the calling package (Brotli). This can lead to
problems in calling code that expects find_package result variables
(e.g., _FOUND) to follow a certain pattern.
Call Stack (most recent call first):
CMake/FindBrotli.cmake:31 (find_package_handle_standard_args)
CMakeLists.txt:713 (find_package)
This warning is for project developers. Use -Wno-dev to suppress it.

@jay jay closed this in 1df2dfb Feb 12, 2023
@jay
Copy link
Member

jay commented Feb 12, 2023

Thanks. Note recent CMake should always set the uppercase version (ie BROTLI_FOUND) even if the case is mixed.

@data-man data-man deleted the fix_brotli_name branch February 12, 2023 15:34
bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
@data-man @bch
cmake: fix dev warning due to mismatched arg
4094fc9 
The package name passed to find_package_handle_standard_args (BROTLI)
does not match the name of the calling package (Brotli). This can lead
to problems in calling code that expects find_package result variables
(e.g., _FOUND) to follow a certain pattern.

Closes curl#10471
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build cmake
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@data-man @jay